Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana: Upgrades mysql images from 5.7 to 8 #67604

Merged
merged 13 commits into from
May 4, 2023

Conversation

owensmallwood
Copy link
Contributor

@owensmallwood owensmallwood commented May 1, 2023

Adding a build step for mysql8 since we're transitioning to that in cloud.

Enterprise PR

@owensmallwood owensmallwood requested a review from a team May 1, 2023 20:54
@owensmallwood owensmallwood self-assigned this May 1, 2023
@owensmallwood owensmallwood requested a review from a team as a code owner May 1, 2023 20:54
@owensmallwood owensmallwood requested review from a team, papagian, mildwonkey and yangkb09 and removed request for a team May 1, 2023 20:54
@grafanabot grafanabot added the type/ci Tasks related to Continuous Integration workflow label May 1, 2023
@owensmallwood owensmallwood added this to the 10.0.0 milestone May 1, 2023
Copy link
Contributor

@papagian papagian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There some additional references of the 5.7.39 version that we need to address here or in a follow-up:

  • the default version in mysql devenv block
  • the default version in mysql_tests devenv block
  • the default argument for the mysql_tests Dockerfile

@sakjur
Copy link
Contributor

sakjur commented May 2, 2023

🤔 I'm a bit worried that we could end up depending on MySQL 8 features in a migration somewhere without detecting it before shipping since we've committed to supporting MySQL 5.7 (https://grafana.com/docs/grafana/v9.5/setup-grafana/installation/#supported-databases) until it's no longer supported by upstream.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs to be generated with make drone.

@papagian
Copy link
Contributor

papagian commented May 2, 2023

🤔 I'm a bit worried that we could end up depending on MySQL 8 features in a migration somewhere without detecting it before shipping since we've committed to supporting MySQL 5.7 (https://grafana.com/docs/grafana/v9.5/setup-grafana/installation/#supported-databases) until it's no longer supported by upstream.

that's also my concern: ideally we would like to run integration tests both against 5.7 and 8.0

@kminehart
Copy link
Contributor

ideally we would like to run integration tests both against 5.7 and 8.0

Good idea!

@owensmallwood
Copy link
Contributor Author

@sakjur @kminehart @papagian How much work would it be to have our mysql integration tests run against 5.7 and 8? I'm not really familiar with our build pipepine. This PR was mostly to see what would break if we bump the mysql image to 8.

@sakjur
Copy link
Contributor

sakjur commented May 3, 2023

I don't think that would be a lot of work, I'll create a branch to try it out quickly

@sakjur sakjur mentioned this pull request May 3, 2023
3 tasks
@sakjur
Copy link
Contributor

sakjur commented May 3, 2023

Got it working in #67710.

@owensmallwood owensmallwood requested a review from a team as a code owner May 3, 2023 15:48
@owensmallwood owensmallwood requested review from ashharrison90 and removed request for a team May 3, 2023 15:48
@owensmallwood
Copy link
Contributor Author

Thanks @sakjur . I'll do the same thing to the enterprise PR for this

@owensmallwood owensmallwood requested review from a team, mdvictor and baldm0mma and removed request for a team May 3, 2023 16:23
@owensmallwood
Copy link
Contributor Author

@sakjur Do you know how long we're committed to supporting 5.7? Assuming until EOL in October?

@sakjur
Copy link
Contributor

sakjur commented May 4, 2023

Yup, October.

@owensmallwood owensmallwood merged commit a4c7450 into main May 4, 2023
4 checks passed
@owensmallwood owensmallwood deleted the owensmallwood/upgrade-mysql-images-to-8 branch May 4, 2023 17:42
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview, 10.1.x May 31, 2023
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend no-backport Skip backport of PR type/ci Tasks related to Continuous Integration workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants