-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grafana: Upgrades mysql images from 5.7 to 8 #67604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There some additional references of the 5.7.39
version that we need to address here or in a follow-up:
- the default version in
mysql
devenv block - the default version in
mysql_tests
devenv block - the default argument for the
mysql_tests
Dockerfile
🤔 I'm a bit worried that we could end up depending on MySQL 8 features in a migration somewhere without detecting it before shipping since we've committed to supporting MySQL 5.7 (https://grafana.com/docs/grafana/v9.5/setup-grafana/installation/#supported-databases) until it's no longer supported by upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs to be generated with make drone
.
that's also my concern: ideally we would like to run integration tests both against |
Good idea! |
@sakjur @kminehart @papagian How much work would it be to have our mysql integration tests run against 5.7 and 8? I'm not really familiar with our build pipepine. This PR was mostly to see what would break if we bump the mysql image to 8. |
I don't think that would be a lot of work, I'll create a branch to try it out quickly |
Got it working in #67710. |
…d/upgrade-mysql-images-to-8
Thanks @sakjur . I'll do the same thing to the enterprise PR for this |
@sakjur Do you know how long we're committed to supporting 5.7? Assuming until EOL in October? |
Yup, October. |
Adding a build step for mysql8 since we're transitioning to that in cloud.
Enterprise PR