AzureMonitor: Fix logs query multi-resource and timespan values #67914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make them util functions because it's simpler
aangelisc
added
type/bug
datasource/Azure
aangelisc
requested review from
asimpson and
bossinc
and removed request for
a team
|
Backend code coverage report for PR #67914
|
|
Frontend code coverage report for PR #67914 |
grafanabot
pushed a commit
that referenced
this pull request
May 5, 2023
* Update TimeGrain interface methods - Make them util functions because it's simpler * Update logs ds to appropiately set resources and timespan * Set timespan using RCF times * Update tests (cherry picked from commit 9d16718)
grafanabot
pushed a commit
that referenced
this pull request
May 5, 2023
* Update TimeGrain interface methods - Make them util functions because it's simpler * Update logs ds to appropiately set resources and timespan * Set timespan using RCF times * Update tests (cherry picked from commit 9d16718)
grafanabot
pushed a commit
that referenced
this pull request
May 5, 2023
* Update TimeGrain interface methods - Make them util functions because it's simpler * Update logs ds to appropiately set resources and timespan * Set timespan using RCF times * Update tests (cherry picked from commit 9d16718)
aangelisc
added a commit
that referenced
this pull request
May 5, 2023
…lues (#67933) AzureMonitor: Fix logs query multi-resource and timespan values (#67914) * Update TimeGrain interface methods - Make them util functions because it's simpler * Update logs ds to appropiately set resources and timespan * Set timespan using RCF times * Update tests (cherry picked from commit 9d16718) Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
aangelisc
added a commit
that referenced
this pull request
May 5, 2023
…ues (#67932) AzureMonitor: Fix logs query multi-resource and timespan values (#67914) * Update TimeGrain interface methods - Make them util functions because it's simpler * Update logs ds to appropiately set resources and timespan * Set timespan using RCF times * Update tests (cherry picked from commit 9d16718) Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
aangelisc
added a commit
that referenced
this pull request
May 5, 2023
…ues (#67931) AzureMonitor: Fix logs query multi-resource and timespan values (#67914) * Update TimeGrain interface methods - Make them util functions because it's simpler * Update logs ds to appropiately set resources and timespan * Set timespan using RCF times * Update tests (cherry picked from commit 9d16718) Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Log Analytics datasource to appropriately set the resource value if multiple resources are selected and also to correctly set the query timespan.
The endpoint expects the
workspacesproperty to be set if multiple resources are to be queried. The endpoint also expects thetimespanproperty to be set to specify the period of data to be queried. If thetimespanproperty exists and a period is also specified in the query then the intersection of the two periods will be used. See relevant documentation here.Timespans are formatted using
RCF3339.Fixes #67716
Fixes #67717