[v9.5.x] Google Cloud Monitor: Fix mem usage for dropdown #67949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Google Cloud Monitor: Fix mem usage for dropdown Previously the Metric name dropdown would attempt to load _all_ the available metric names into the Select which would eventually crash the browser if the dataset was large enough. We can fix this by using AsyncSelect and making another query once a Service is selected _and_ the user types a few characters. * fix: update tests for AsyncSelect * fix lint * fix: add subset of metrics on initial load (cherry picked from commit b2e1b3a)
grafanabot
added
backport
asimpson
approved these changes
May 5, 2023
|
Backend code coverage report for PR #67949 |
|
Frontend code coverage report for PR #67949
|
zerok
added
add to changelog
and removed
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b2e1b3a from #67683