Heatmap: Fix color rendering for value ranges < 1 #68156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeoniya
added
type/bug
area/panel/heatmap
add to changelog
backport v9.5.x
grafanabot
pushed a commit
that referenced
this pull request
May 10, 2023
(cherry picked from commit 1400a0a)
grafanabot
pushed a commit
that referenced
this pull request
May 10, 2023
(cherry picked from commit 1400a0a)
leeoniya
added a commit
that referenced
this pull request
May 10, 2023
leeoniya
added a commit
that referenced
this pull request
May 10, 2023
ryantxu
pushed a commit
that referenced
this pull request
May 11, 2023
ryantxu
pushed a commit
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65302
this was a 0-divisor guard (when min === max) made with the assumption that heatmap cells were always counts and could not be < 1.
heatmap-colors.json
{ "annotations": { "list": [ { "builtIn": 1, "datasource": { "type": "grafana", "uid": "-- Grafana --" }, "enable": true, "hide": true, "iconColor": "rgba(0, 211, 255, 1)", "name": "Annotations & Alerts", "type": "dashboard" } ] }, "editable": true, "fiscalYearStartMonth": 0, "graphTooltip": 0, "id": 658, "links": [], "liveNow": false, "panels": [ { "datasource": { "type": "testdata", "uid": "PD8C576611E62080A" }, "fieldConfig": { "defaults": { "custom": { "hideFrom": { "legend": false, "tooltip": false, "viz": false }, "scaleDistribution": { "type": "linear" } } }, "overrides": [] }, "gridPos": { "h": 14, "w": 24, "x": 0, "y": 0 }, "id": 1, "options": { "calculate": false, "cellGap": 1, "color": { "exponent": 0.5, "fill": "dark-orange", "mode": "scheme", "reverse": false, "scale": "exponential", "scheme": "Spectral", "steps": 64 }, "exemplars": { "color": "rgba(255,0,255,0.7)" }, "filterValues": { "le": 1e-9 }, "legend": { "show": true }, "rowsFrame": { "layout": "auto" }, "tooltip": { "show": true, "yHistogram": false }, "yAxis": { "axisPlacement": "left", "reverse": false } }, "pluginVersion": "10.1.0-pre", "targets": [ { "datasource": { "type": "testdata", "uid": "PD8C576611E62080A" }, "rawFrameContent": "[\n {\n \"schema\": {\n \"refId\": \"A\",\n \"fields\": [\n {\n \"name\": \"time\",\n \"type\": \"time\",\n \"typeInfo\": {\n \"frame\": \"time.Time\"\n },\n \"config\": {}\n },\n {\n \"name\": \"A-series\",\n \"type\": \"number\",\n \"typeInfo\": {\n \"frame\": \"float64\",\n \"nullable\": true\n },\n \"config\": {}\n }\n ]\n },\n \"data\": {\n \"values\": [\n [\n 1683669542644,\n 1683671942644,\n 1683674342644,\n 1683676742644,\n 1683679142644,\n 1683681542644,\n 1683683942644,\n 1683686342644,\n 1683688742644,\n 1683691142644\n ],\n [\n 20,\n 20.01,\n 20.02,\n 20.03,\n 20.04,\n 20.05,\n 20.06,\n 20.07,\n 20.08,\n 20.09\n ]\n ]\n }\n }\n]", "refId": "A", "scenarioId": "raw_frame" } ], "title": "Panel Title", "type": "heatmap" } ], "refresh": false, "schemaVersion": 38, "style": "dark", "tags": [], "templating": { "list": [] }, "time": { "from": "2023-05-09T21:12:08.356Z", "to": "2023-05-10T04:06:09.539Z" }, "timepicker": {}, "timezone": "", "title": "heatmap-colors", "uid": "c43d1a41-98f0-45c5-bf21-b17eff49f55f", "version": 3, "weekStart": "" }before:
after: