-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NewsDrawer: Add grot to news drawer (after news items) #68173
Conversation
@torkelo i think this doesn't quite feel right. Grot has to get too big for the meaning of the image to be clear. In this placement I think the larger it gets the more distracting and out of place it feels. We can try for a simpler version but I would probably skip. |
@ergoerik what about this? Having it at the bottom for those that happen to scroll to the end, he becomes more subtle, almost like an easter egg -api-ds-query---HTTP-handlers---Grafana-Monitoring---Scenes---Dashboards---Grafana.webm |
@torkelo here's an updated image with little spiral on the newspaper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's cute to include Grot here for sure and love the updated image with our spiral on the newspaper. I just wonder if having it at the bottom means it will be invisible. This doesn't hurt anything so I'm game to include it, but I wonder if we can pull down how often news is being read.
@amy-super yea, I don't think it will be very common for people to scroll to the bottom, which this is more of a easter egg :) But I can't think of another way to fit him in that doesn't feel out of place. Do you have any ideas? |
What about something like this @torkelo @amy-super |
@ergoerik the drawer opens under topnav so there is not that much room for a larger grot Something like this could maybe work? @amy-super what do you think? |
I think this could work. Prefer this to the option with Grot right aligned because it connects the words and image as a single idea/thought. If this small, Grot without the amoeba could work better: |
Agree I prefer the centered one - and dropping the amoeba should be OK in dark mode as well. And in the end, I think it's OK that Grot is a little smaller but more visible (over the idea of dropping it at the end). |
This looks awesome! I agree with Amy's comments on this - centered and amoeba free 😄 |
Ok pushed an update. I think this size works pretty well, you clearly see what Grot is doing but it's not taking too much space from the drawer (news items). Oh, and I added a border. With or without border that is the question? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
With the border! Looks great ❤️ |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-68173-to-v10.0.x origin/v10.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x c8fd3c20cd9f5a30ea3908f5da44ef5f92deb10d
# Push it to GitHub
git push --set-upstream origin backport-68173-to-v10.0.x
git switch main
# Remove the local backport branch
git branch -D backport-68173-to-v10.0.x Then, create a pull request where the |
* NewsDrawer: Add grot to drawer header * Update * Move to bottom * Updates * reverted unrelated change * Update * fixing test (cherry picked from commit c8fd3c2)
* NewsDrawer: Add grot to drawer header * Update * Move to bottom * Updates * reverted unrelated change * Update * fixing test
Ok final version a more subtle one hidden after the last news item:
Grafana.1.webm
Discarded ideas (placing him in the header before the drawer title)
![image](https://private-user-images.githubusercontent.com/10999/237318122-f827cefd-5849-4378-8357-ac0f092e6d3c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxODg1NjcsIm5iZiI6MTcyMjE4ODI2NywicGF0aCI6Ii8xMDk5OS8yMzczMTgxMjItZjgyN2NlZmQtNTg0OS00Mzc4LTgzNTctYWMwZjA5MmU2ZDNjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDE3Mzc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUwYzczOWNiYjFjZjI3ZjMyNTU2NzdjM2ZhZjhkNmYzNGI5ZjFjNTE2NTMzZTAxMzQ3NzcxY2Y0ZDNjNWJkODUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.3O-7fibEDc_lXcV7BTWEoQMmrniQ7vBbA0KCJGyKuJc)
A bit bigger
![image](https://private-user-images.githubusercontent.com/10999/237318402-d1b295e3-12ae-4cb4-aa7f-0f8acf1dc8d9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxODg1NjcsIm5iZiI6MTcyMjE4ODI2NywicGF0aCI6Ii8xMDk5OS8yMzczMTg0MDItZDFiMjk1ZTMtMTJhZS00Y2I0LWFhN2YtMGY4YWNmMWRjOGQ5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDE3Mzc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNlZjUzYmRjNTRiZWI2NTlmMmIzN2EzMGQyODFkMDkzYmZiODk4ZDJjMDg1MTlmZWI1ZmYwMzZmYWZkYTNiOTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.7WGjWjVQ9zW2i2x4peqAqkiXxEHv1n6fPT1rQXyfMI0)
A lot bigger:
![Screenshot from 2023-05-10 09-57-29](https://private-user-images.githubusercontent.com/10999/237318866-1139c3be-863d-41c4-a7ea-d594b1b85fd5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxODg1NjcsIm5iZiI6MTcyMjE4ODI2NywicGF0aCI6Ii8xMDk5OS8yMzczMTg4NjYtMTEzOWMzYmUtODYzZC00MWM0LWE3ZWEtZDU5NGIxYjg1ZmQ1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDE3Mzc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJmMGE4YTFjMDY3MTg0ZjNlZDUxYmJmMjNiNjEwNjQ3MmJiMjExNmU0ZjQyNDEzNjA3MzUwZmQ4NDdlM2UyNDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.XYyNOxnbdoSH66Tcg78lexTHoeziaL1BNpvEtc0s1zs)