Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saga DS - Spacing Tokens [epic] #68219

Closed
2 of 7 tasks
staton-hyse11 opened this issue May 10, 2023 · 2 comments
Closed
2 of 7 tasks

Saga DS - Spacing Tokens [epic] #68219

staton-hyse11 opened this issue May 10, 2023 · 2 comments
Assignees
@staton-hyse11
Labels
area/ux saga design system Issues related to the work of the Saga Design System type/epic Issue made of smaller issues

Comments

@staton-hyse11
Copy link
Contributor

staton-hyse11 commented May 10, 2023 •
edited

Establish a spacing system

Tasks
Beta Give feedback
  1. Spacing Tokens [explore] #68660
    3 of 3
    saga design system
    staton-hyse11
  2. Spacing Tokens [design] #69184
    0 of 2
    area/ux saga design system saga ds: pattern
    staton-hyse11
  3. Saga DS - Spacing Tokens [build] #69134
    saga design system

Other Tasks
Beta Give feedback
@staton-hyse11 staton-hyse11 added the saga design system Issues related to the work of the Saga Design System label May 10, 2023
@staton-hyse11 staton-hyse11 self-assigned this May 12, 2023
@L-M-K-B
Copy link
Contributor

L-M-K-B commented May 12, 2023

Dev reminder: When implementing new tokens we need to keep in mind that theme.spacing(number) is returning a string incl. 'px' at the end which is doesn't come in handy when we need to calculate some other value with it.

@L-M-K-B L-M-K-B mentioned this issue May 12, 2023
Merged
@JoaoSilvaGrafana JoaoSilvaGrafana added the type/epic Issue made of smaller issues label May 16, 2023
@JoaoSilvaGrafana JoaoSilvaGrafana mentioned this issue Jul 5, 2023
Closed
@staton-hyse11 staton-hyse11 mentioned this issue Jul 17, 2023
Closed
@staton-hyse11
Copy link
Contributor Author

closing this to keep token tracking in #80673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staton-hyse11 staton-hyse11

Labels
area/ux saga design system Issues related to the work of the Saga Design System type/epic Issue made of smaller issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@L-M-K-B @JoaoSilvaGrafana @staton-hyse11