Breadcrumbs: Don't add breadcrumb for the current tab #68230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
requested review from
ashharrison90 and
eledobleefe
and removed request for
a team
torkelo
added
product-approved
torkelo
changed the title
ashharrison90
approved these changes
May 11, 2023
There was a problem hiding this comment.
@torkelo have to confess i also can't really remember the problem this was supposed to fix 😅
have looked through the old PR that added it (#61835) and had a play around locally and from what i can tell the changes seem fine.
maybe it would be safer if this doesn't get backported though. would give us a lot more time to spot any potential problems? up2u 🤔
torkelo
added
no-backport
ryantxu
pushed a commit
that referenced
this pull request
May 11, 2023
Breadcrumbs: Don't add breadcrumbs for the current tab
ryantxu
pushed a commit
that referenced
this pull request
May 16, 2023
Breadcrumbs: Don't add breadcrumbs for the current tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why I added this, it is useful for pages with many tabs to find your way back to the "home" / default tab. But with scene drilldowns creating deep breadcrumbs, anything we can do to limit the number is good. It's also not great for mobile views because if we show the current tab, we have to have 3 breadcrumbs to find your way back to your the parent "page".
Before:
After:
