Accessibility: Adds aria tags to VizTooltip so screen readers announce them #68247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoSilvaGrafana
added
add to changelog
type/accessibility
JoaoSilvaGrafana
requested review from
a team,
tskarhed and
L-M-K-B
and removed request for
a team
JoaoSilvaGrafana
changed the title
Clarity-89
approved these changes
May 11, 2023
ryantxu
pushed a commit
that referenced
this pull request
May 11, 2023
ryantxu
pushed a commit
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This adds
aria-liveto theVizTooltipContainerso that it is read out to screen readers when it shows up on screen. Also addedaria-atomicfor it to always read the whole content and not only what has changed, otherwise only the timestamp and values that changed would be read out.Before:
Screen.Recording.2023-05-10.at.16.52.58.mov
After:
Screen.Recording.2023-05-10.at.16.51.57.mov
Why do we need this feature?
So that users with screen readers can get the information about the data.
Who is this feature for?
Screen reader users
Which issue(s) does this PR fix?:
Fixes #66549
Special notes for your reviewer:
Please check that: