Build: Update plugin installation in custom Dockerfile #68310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
There is a for loop in the plugin installation layer in the custom Dockerfile. The problem is that if the installation of any plugin except the last one faces an error (e.g., Network error and etc.), the layer will continue to run and the image is built successfully, and the user may not be aware of the missing plugins in the image.
This PR adds the
set -e
command to the layer to exit the layer with a non-zero code in case of any failure in the loop and prevent the image from building successfully.Why do we need this feature?
Users should be certain about the successful installation of all plugins, especially for the CI/CD pipelines.
Who is this feature for?
Anyone who uses the custom Dockerfile for pre-installed plugins.
Special notes for your reviewer:
Please check that: