Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: Add ability to override skip_org_role_sync with Env variables #68364

Merged
merged 1 commit into from
May 12, 2023
Merged

Settings: Add ability to override skip_org_role_sync with Env variables #68364

merged 1 commit into from
May 12, 2023

Conversation

eleijonmarck
Copy link
Contributor

What is this feature?

  • Adds the ability to override the skip_org_role_sync settings w. env variables

Why do we need this feature?

  • we need this for users that want to override these settings using env variables

Usage: "Fixes #", or "Fixes (paste link of issue)"
https://github.com/grafana/support-escalations/issues/5891

@eleijonmarck eleijonmarck added this to the 10.0.x milestone May 12, 2023
@eleijonmarck eleijonmarck added backport v9.5.x Bot will automatically open backport PR backport v10.0.x add to changelog and removed area/backend labels May 12, 2023
@eleijonmarck eleijonmarck changed the title Settings: Switch to using the SectionsWithOverride for skip_org_role_sync Settings: Add ability to override skip_org_role_sync with Env variables May 12, 2023
@grafana grafana deleted a comment from grafanabot May 12, 2023
@grafana grafana deleted a comment from grafanabot May 12, 2023
@eleijonmarck eleijonmarck marked this pull request as ready for review May 12, 2023 11:36
@eleijonmarck eleijonmarck requested a review from a team as a code owner May 12, 2023 11:36
@eleijonmarck eleijonmarck requested review from sakjur, papagian and yangkb09 and removed request for a team May 12, 2023 11:36
@eleijonmarck eleijonmarck merged commit 1a79c8a into main May 12, 2023
26 checks passed
@eleijonmarck eleijonmarck deleted the eleijonmarck/skip-org-role-sync/enable-env branch May 12, 2023 12:45
@grafanabot grafanabot mentioned this pull request May 12, 2023
Merged
grafanabot pushed a commit that referenced this pull request May 12, 2023
@eleijonmarck @grafanabot
Settings: Add ability to override skip_org_role_sync with Env varia…
b0e85d8 
…bles (#68364)

Switch to using the SectionsWithOverride for settings for skip org role sync

(cherry picked from commit 1a79c8a)
@grafanabot grafanabot mentioned this pull request May 12, 2023
Merged
grafanabot pushed a commit that referenced this pull request May 12, 2023
@eleijonmarck @grafanabot
Settings: Add ability to override skip_org_role_sync with Env varia…
ae3d93b 
…bles (#68364)

Switch to using the SectionsWithOverride for settings for skip org role sync

(cherry picked from commit 1a79c8a)
eleijonmarck added a commit that referenced this pull request May 12, 2023
@grafanabot @eleijonmarck
[v10.0.x] Settings: Add ability to override skip_org_role_sync with…
fe15f75 
… Env variables (#68376)

Settings: Add ability to override `skip_org_role_sync` with Env variables (#68364)

Switch to using the SectionsWithOverride for settings for skip org role sync

(cherry picked from commit 1a79c8a)

Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>
eleijonmarck added a commit that referenced this pull request May 12, 2023
@grafanabot @eleijonmarck
[v9.5.x] Settings: Add ability to override skip_org_role_sync with …
dd33560 
…Env variables (#68375)

Settings: Add ability to override `skip_org_role_sync` with Env variables (#68364)

Switch to using the SectionsWithOverride for settings for skip org role sync

(cherry picked from commit 1a79c8a)

Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>
ryantxu pushed a commit that referenced this pull request May 16, 2023
@eleijonmarck @ryantxu
Settings: Add ability to override skip_org_role_sync with Env varia…
eff28db 
…bles (#68364)

Switch to using the SectionsWithOverride for settings for skip org role sync
@zerok zerok modified the milestones: 10.0.x, 10.0.0-preview, 10.1.x May 31, 2023
@eleijonmarck eleijonmarck mentioned this pull request Jun 21, 2023
Closed
kminehart pushed a commit that referenced this pull request Jun 22, 2023
@grafanabot @eleijonmarck @zerok
[v9.5.x] Settings: Add ability to override skip_org_role_sync with …
12093e5 
…Env variables (#68375)

Settings: Add ability to override `skip_org_role_sync` with Env variables (#68364)

Switch to using the SectionsWithOverride for settings for skip org role sync

(cherry picked from commit 1a79c8a)

Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gamab gamab gamab approved these changes

@sakjur sakjur Awaiting requested review from sakjur sakjur was automatically assigned from grafana/backend-platform

@papagian papagian Awaiting requested review from papagian papagian was automatically assigned from grafana/backend-platform

@yangkb09 yangkb09 Awaiting requested review from yangkb09 yangkb09 was automatically assigned from grafana/backend-platform

Assignees
No one assigned
Labels
add to changelog area/backend backport v9.5.x Bot will automatically open backport PR backport v10.0.x type/bug
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eleijonmarck @gamab @zerok @ricky-undeadcoders @grafanabot