Alerting: Reorder new alert and export buttons #68418
Conversation
VikaCep
force-pushed
the
alerting/68093-alert-buttons
branch
from
8985d83
to
c12cb7b
Compare
VikaCep
added
area/alerting
|
Should we remove the |
| @@ -235,6 +235,17 @@ const unifiedRoutes: RouteDescriptor[] = [ | |||
| () => import(/* webpackChunkName: "AlertingRuleForm"*/ 'app/features/alerting/unified/RuleEditor') | |||
| ), | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
It seems to me the current number of routes is a bit confusing. We have
/alerting/new/alerting/new/grafana/alerting/new/cloud-alerting/alerting/new/cloud-recording
What if we have/alerting/new/alertingand/alerting/new/recording?
There was a problem hiding this comment.
And what about Loki/Mimir? (currently cloud-alerting), shouldn't we add a new route for it as well?
There was a problem hiding this comment.
I think both Grafana and Loki/Mimir should be under /alerting/new/alerting.
My rationale is that you click Create Alert Rule or More -> Create recording rule so we have two different entry points. Additionally, if we remove the Recording rule from the rule type selection, this routing change makes more sense. Yet it makes less sense if we do not remove the Recording rule from the type selection.
There was a problem hiding this comment.
It sounds good to me, removed the button and changed the routes as you suggested 👍
VikaCep
requested review from
ashharrison90,
eledobleefe and
konrad147
and removed request for
a team
| </LinkButton> | ||
| )} | ||
|
|
||
| <Dropdown overlay={newMenu}> |
There was a problem hiding this comment.
Should we hide the dropdown if none of canCreateGrafanaRules, canCreateCloudRules, and canReadProvisioning is true?
VikaCep
removed
the
no-changelog
What is this feature?
Moves the new alert rule button to the top and creates a dropdown to display the options to create a recording rule and export all rules.
Now each new rule option has its own path: Grafana and Loki/Mimir are under
new/alertingwhile recording rules can be accessed fromnew/recording.Why do we need this feature?
To group buttons in a more clear way.
Who is this feature for?
All users
Which issue(s) does this PR fix?:
Fixes #68093
Fixes #68185