-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policies: Adds deprecation policy #68439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like where this is headed! Added a few suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if I were to add anything it would be guidance about the time between disable-by-default and full removal.
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Signed-off-by: bergquist <carl.bergquist@gmail.com>
Co-authored-by: Dan Cech <dcech@grafana.com>
Co-authored-by: Dan Cech <dcech@grafana.com>
Co-authored-by: Dan Cech <dcech@grafana.com>
Co-authored-by: Dan Cech <dcech@grafana.com>
Co-authored-by: Dan Cech <dcech@grafana.com>
Co-authored-by: Dan Cech <dcech@grafana.com>
Signed-off-by: bergquist <carl.bergquist@gmail.com>
Co-authored-by: Dan Cech <dcech@grafana.com>
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
Signed-off-by: bergquist <carl.bergquist@gmail.com>
2f61f36
to
29c4e70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for putting this together.
Based on the internal document that have been circulated for a while.
I'm not sure what the best place would be but I figure this belongs more under contributing than docs? But more than happy to change it.