GrafanaUI: Support Tooltip as Dropdown child #68521
Merged
+142
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhunt
added
type/bug
add to changelog
mob session
joshhunt
requested review from
ashharrison90 and
L-M-K-B
and removed request for
a team
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-68521-to-v10.0.x origin/v10.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 7b3221d494bd6aea82cda5ccef2bec4d42fa19b1
# Push it to GitHub
git push --set-upstream origin backport-68521-to-v10.0.x
git switch main
# Remove the local backport branch
git branch -D backport-68521-to-v10.0.xThen, create a pull request where the |
grafanabot
added
the
backport-failed
ryantxu
pushed a commit
that referenced
this pull request
May 16, 2023
Co-authored-by: eledobleefe <laura.fernandez@grafana.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com> Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com
joshhunt
added a commit
that referenced
this pull request
May 17, 2023
Co-authored-by: eledobleefe <laura.fernandez@grafana.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com> Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com (cherry picked from commit 7b3221d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Support using
Dropdownwith a child button with a tooltip likeWhy do we need this feature?
Especially so IconButton can be used better as a Dropdown trigger
Who is this feature for?
UI and Plugin developers :)
Which issue(s) does this PR fix?:
Fixes #65632
Special notes for your reviewer:
Have a nice day :)