Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loki: Preserve pre-selected labels in the log context UI #68700

Merged
merged 3 commits into from
May 22, 2023
Merged

Loki: Preserve pre-selected labels in the log context UI #68700

merged 3 commits into from
May 22, 2023

Conversation

ivanahuckova
Copy link
Member

In this PR, we are introducing a new functionality to Loki log context UI. We are using local storage to save removed labels and added extracted labels and then use them in a new log context window. The main goal is to reduce repetition when users are going trough multiple log lines and they always have to select/remove same labels.

Functionalities

  • We've added button to reset query to initial query. It also deletes saved context labels from local storage
  • We show standard Grafana notification when context is opened and previously selected labels were used
  • If query with applied preserved labels will produce invalid stream selector without labels, we use original labels, we but don’t remove labels from local storage
filters.mov

@ivanahuckova ivanahuckova added this to the 10.1.x milestone May 18, 2023
@ivanahuckova ivanahuckova self-assigned this May 18, 2023
@ivanahuckova ivanahuckova requested a review from a team as a code owner May 18, 2023 12:39
@github-actions
Copy link
Contributor

Backend code coverage report for PR #68700
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #68700

Plugin Main PR Difference
loki 84.65% 84.75% .10%

svennergr
svennergr approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@svennergr svennergr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I really like that feature!

public/app/plugins/datasource/loki/components/LokiContextUi.tsx Outdated Show resolved Hide resolved
public/app/plugins/datasource/loki/components/LokiContextUi.tsx Outdated Show resolved Hide resolved
@ivanahuckova ivanahuckova enabled auto-merge (squash) May 22, 2023 08:34
@ivanahuckova ivanahuckova merged commit 7c7e021 into main May 22, 2023
6 checks passed
@ivanahuckova ivanahuckova deleted the ivana/log-context-preserve branch May 22, 2023 08:41
@ivanahuckova ivanahuckova mentioned this pull request May 22, 2023
Merged
ryantxu pushed a commit that referenced this pull request May 22, 2023
@ivanahuckova @ryantxu
Loki: Preserve pre-selected labels in the log context UI (#68700)
40ce6ab 
* WIP

* Refactor and add tests

* Update
This was referenced May 29, 2023
Closed
Merged
svennergr pushed a commit that referenced this pull request Jul 12, 2023
@ivanahuckova @svennergr
Loki: Preserve pre-selected labels in the log context UI (#68700)
6e9e1bc 
* WIP

* Refactor and add tests

* Update
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svennergr svennergr svennergr approved these changes

Assignees

@ivanahuckova ivanahuckova

Labels
add to changelog area/frontend datasource/Loki no-backport Skip backport of PR type/feature-request
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ivanahuckova @svennergr @ricky-undeadcoders @grafanabot