-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing: Upgrade tracing data source configuration editors #68764
Conversation
Backend code coverage report for PR #68764 |
Frontend code coverage report for PR #68764
|
Also just fyi, the auth component and description component are available. |
@@ -21,23 +44,71 @@ export const ConfigEditor = ({ options, onOptionsChange }: Props) => { | |||
secureSocksDSProxyEnabled={config.secureSocksDSProxyEnabled} | |||
/> | |||
|
|||
<div className="gf-form-group"> | |||
<ConfigSection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like these config section are the same across the data sources. Could we just export the section from the TraceToLogsSettings (and other) components? That way we don't have to construct the ConfigSection and export the string constants everywhere.
Thanks for the feedback, all comments addressed. Edit: Ok now they are addressed :D |
public/app/features/explore/TraceView/components/settings/SpanBarSettings.tsx
Outdated
Show resolved
Hide resolved
public/app/features/explore/TraceView/components/settings/SpanBarSettings.tsx
Outdated
Show resolved
Hide resolved
* Add tracing config sub sections * Export common sections and update divider in additional settings section * Max width and margin bottom * Add feature name to config link * Update SpanBarSettings * remove import
What is this feature?
Upgrades configuration editors in Tempo/Jaeger/Zipkin.
Why do we need this feature?
A lot of great work has gone into designing new configuration editors. This PR works that into our Tempo/Jaeger/Zipkin data sources.
Who is this feature for?
Users of Tempo/Jaeger/Zipkin.
Special notes for your reviewer:
Screen.Recording.2023-05-22.at.09.44.41.mov
Please check that: