Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.0.x] AzureMonitor: Ensure legacy properties containing template variables are correctly migrated #68792

Merged
merged 1 commit into from
May 22, 2023
Merged

[v10.0.x] AzureMonitor: Ensure legacy properties containing template variables are correctly migrated #68792

merged 1 commit into from
May 22, 2023

Conversation

grafanabot
Copy link
Contributor

Backport 0be29b4 from #68697

@aangelisc @grafanabot
AzureMonitor: Ensure legacy properties containing template variables …
13fa9e0 
…are correctly migrated (#68697)

* Update migration ordering

- Update migration in applyTemplateVariables to account for interpolation from expression datasource
- Update mock to ensure overrides are passed through correctly
- Update tests
- Update migrateQuery function name for clarity

* Fix tests

* Remove comment

(cherry picked from commit 0be29b4)
@grafanabot grafanabot requested a review from a team as a code owner May 22, 2023 10:14
@grafanabot grafanabot requested review from aangelisc, alyssabull, a team, asimpson and bossinc and removed request for a team, aangelisc and alyssabull May 22, 2023 10:14
@grafanabot grafanabot added backport A backport PR no-changelog Skip including change in changelog/release notes type/bug datasource/Azure Azure Monitor Datasource area/frontend labels May 22, 2023
@aangelisc aangelisc added this to the 10.0.0 milestone May 22, 2023
@aangelisc aangelisc enabled auto-merge (squash) May 22, 2023 10:21
@aangelisc aangelisc merged commit 7d4da5c into v10.0.x May 22, 2023
21 checks passed
@aangelisc aangelisc deleted the backport-68697-to-v10.0.x branch May 22, 2023 10:25
@github-actions
Copy link
Contributor

Backend code coverage report for PR #68792
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #68792

Plugin Main PR Difference
azuremonitor 84.61% 84.61% 0%

@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
@torkelo torkelo added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Jun 9, 2023
@jdbaldry jdbaldry mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
add to changelog area/frontend backport A backport PR datasource/Azure Azure Monitor Datasource type/bug
Projects
None yet
Milestone
10.0.0-preview
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grafanabot @aangelisc @zerok @torkelo