[v10.0.x] Alerting: Fix stale query preview error #68836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use mutable ref to keep queries to be previewed to prevent stale state * Extract code related to AlertQueryRunner to a separate hook * Use hooks form state to keep fresh queries, fix recording rules preview * Remove unused import * Update query update explanation (cherry picked from commit b37a6e9)
grafanabot
added
backport
konrad147
approved these changes
May 22, 2023
torkelo
added
add to changelog
and removed
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b37a6e9 from #68619