Pyroscope: Rename phlare to grafana-pyroscope-datasource #68859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>
ryantxu
added
type/chore
no-backport
ryantxu
requested review from
aocenas
and removed request for
a team,
leventebalogh,
marefr,
papagian,
suntala,
L-M-K-B and
eledobleefe
ryantxu
added
add to changelog
and removed
no-changelog
ryantxu
changed the title
ryantxu
added
the
datasource/grafana-pyroscope
|
@aocenas -- i think this is good to go, but will wait for your ✅ before merging :) |
wbrowne
reviewed
Jun 6, 2023
pkg/plugins/plugins.go
Outdated
| @@ -165,6 +166,10 @@ func ReadPluginJSON(reader io.Reader) (JSONData, error) { | |||
| switch plugin.ID { | |||
| case "grafana-piechart-panel": | |||
| plugin.Name = "Pie Chart (old)" | |||
| case "grafana-pyroscope": // rebranding | |||
There was a problem hiding this comment.
Suggested change
| case "grafana-pyroscope": // rebranding | |
| case "grafana-pyroscope-datasource": // rebranding |
and subsequently the Phlare<>Pyroscope rebranding -- hardcoded alias test
|
Looks like this works, don't really understand the code well enough to comment on that but seems like there was discussion enough about that already. Just wondering why |
all normal plugins end with their plugin type... typically |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the builtin "phlare" datasource to "grafana-pyroscope-datasource" and adds registers an alias in the plugin registry. This will keep existing settings working while allowing us to rebrand the plugin.
Depends on #67867, starts to address #17186
Alternative to:
#67847
#67490