Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox: Fix extraneous right hand margin when no label is present #68885

Merged
merged 2 commits into from May 24, 2023

Conversation

ashharrison90
Copy link
Contributor

What is this feature?

  • removes explicit grid templating and just lets the browser work it out automatically
    • this feels a bit scary 😬
    • have checked storybook in chrome/firefox/safari and seems good
    • have also played around locally and can't see any issues, but this would probably be good to get others to test and confirm

Why do we need this feature?

  • so checkboxes without a label don't have extraneous right hand margin

Who is this feature for?

  • everyone!

Which issue(s) does this PR fix?:

Fixes #68884

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ashharrison90 ashharrison90 added type/bug add to changelog no-backport Skip backport of PR saga design system Issues related to the work of the Saga Design System labels May 23, 2023
@ashharrison90 ashharrison90 added this to the 10.1.x milestone May 23, 2023
@ashharrison90 ashharrison90 self-assigned this May 23, 2023
@ashharrison90 ashharrison90 requested a review from a team as a code owner May 23, 2023 12:45
@ashharrison90 ashharrison90 requested review from joshhunt and removed request for a team May 23, 2023 12:45
Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it feels a bit scary but I can't see it changing anything when it is removed, so... lgtm? 👏

@ashharrison90 ashharrison90 merged commit 09a0c1e into main May 24, 2023
23 checks passed
@ashharrison90 ashharrison90 deleted the ash/68884 branch May 24, 2023 09:52
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend no-backport Skip backport of PR saga design system Issues related to the work of the Saga Design System type/bug
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Checkbox column too wide (checkbox has 8px extra too the right)
4 participants