Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlameGraph: Add option to align text left or right #68893

Merged
merged 3 commits into from
May 25, 2023

Conversation

aocenas
Copy link
Member

@aocenas aocenas commented May 23, 2023

Screen.Recording.2023-05-23.at.15.23.31.mov

Also changes some css to align a bit with the button in graph panel.

There is a bit of special behaviour:

  • if the label (without the value part) fits in the node the alignment has no effect
  • if aligned to the right it does not show the value part as main point imho to see the function name in this case

Known issues:

@aocenas aocenas added this to the 10.1.x milestone May 23, 2023
@aocenas aocenas requested review from a team as code owners May 23, 2023 13:29
@aocenas aocenas requested review from ashharrison90, JoaoSilvaGrafana and mckn and removed request for a team May 23, 2023 13:29
Copy link
Contributor

@joey-grafana joey-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

One nit, the icon buttons would look even better if either the right margin was removed or the icons were center aligned in the buttons.

Screenshot 2023-05-25 at 09 48 29 Screenshot 2023-05-25 at 09 50 49

@aocenas
Copy link
Member Author

aocenas commented May 25, 2023

@joey-grafana yeah I mention it in the description, created a separate PR for that.

@aocenas aocenas merged commit 55bba16 into main May 25, 2023
11 checks passed
@aocenas aocenas deleted the aocenas/flamegraph/text-align branch May 25, 2023 09:08
@joey-grafana
Copy link
Contributor

@joey-grafana yeah I mention it in the description, created a separate PR for that.

Ahh, I read it and everything but slipped my mind during the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants