Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus: Create endpoint checker for api calls #68907

Closed
itsmylife opened this issue May 23, 2023 · 2 comments
Closed

Prometheus: Create endpoint checker for api calls #68907

itsmylife opened this issue May 23, 2023 · 2 comments
Labels
datasource/Prometheus needs research for internal issues needing more research type/feature-request

Comments

@itsmylife
Copy link
Contributor

itsmylife commented May 23, 2023 •
edited

We have different versions of Prometheus and different flavors of Prometheus like Mimir, Thanos, Cortex, etc. Some of those are supporting particular endpoints and some of them are not. Like labelsMatch endpoint or rules endpoint.

In order to handle API calls properly we need to know if the given flavor and version of Prometheus is supporting a particular endpoint. We should not make calls to a non-supported endpoint. It is just a waste of resources.

Related Issues:
@itsmylife itsmylife added datasource/Prometheus needs research for internal issues needing more research type/feature-request labels May 23, 2023
@gtk-grafana
Copy link
Contributor

I'm almost thinking a much simpler config field that just allows folks to build a deny-list for api endpoints, the use-cases don't always match up with the type/version.

@gtk-grafana
Copy link
Contributor

Related: #70903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
datasource/Prometheus needs research for internal issues needing more research type/feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itsmylife @gtk-grafana