Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loki: Implement decolorize logql operation #68972

Merged
merged 2 commits into from May 24, 2023
Merged

Loki: Implement decolorize logql operation #68972

merged 2 commits into from May 24, 2023

Conversation

ivanahuckova
Copy link
Member

In this PR we are:

  • Updating lezer parser to 0.1.5 version that includes decolorize Grammar: Add decolorize pipe operation lezer-logql#27
  • Implementing decolorize in autocompletion in code editor
  • Implementing validation for decolorize
  • Adding it to query builder
  • Add it to query parser that translates logql to visual query model

Fixes #68722

Special notes for your reviewer:

How to test this:

decolorize.mov

@ivanahuckova ivanahuckova requested review from a team as code owners May 24, 2023 12:14
@ivanahuckova ivanahuckova requested review from kaydelaney and removed request for a team May 24, 2023 12:14
@ivanahuckova ivanahuckova requested review from matyax and removed request for kaydelaney May 24, 2023 12:15
@ivanahuckova ivanahuckova self-assigned this May 24, 2023
@ivanahuckova ivanahuckova added this to the 10.1.x milestone May 24, 2023
matyax
matyax approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both query editor and builder and looks good! 🥇

@github-actions
Copy link
Contributor

Backend code coverage report for PR #68972
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #68972

Plugin Main PR Difference
loki 84.75% 84.76% .01%

@ivanahuckova ivanahuckova merged commit ca44164 into main May 24, 2023
14 checks passed
@ivanahuckova ivanahuckova deleted the ivana/implement-decolorize branch May 24, 2023 13:23
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyax matyax matyax approved these changes

Assignees

@ivanahuckova ivanahuckova

Labels
add to changelog area/frontend datasource/Loki no-backport Skip backport of PR
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

Loki: Implement "decolorize" operation
4 participants
@ivanahuckova @matyax @ricky-undeadcoders @grafanabot