Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmModal: Ignore case for confirmation text #69000

Merged
merged 3 commits into from
May 31, 2023
Merged

Conversation

ashharrison90
Copy link
Contributor

What is this feature?

  • ignores case when checking the confirmation text
  • adds some quotes around the confirmation text
  • adds a couple of unit tests to prevent regressions in behaviour

Why do we need this feature?

  • slightly easier to use

Who is this feature for?

  • everyone

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ashharrison90 ashharrison90 added area/grafana/ui Issues that belong to components in the @grafana/ui library no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes saga design system Issues related to the work of the Saga Design System labels May 24, 2023
@ashharrison90 ashharrison90 added this to the 10.1.x milestone May 24, 2023
@ashharrison90 ashharrison90 self-assigned this May 24, 2023
@ashharrison90 ashharrison90 requested a review from a team as a code owner May 24, 2023 15:10
@ashharrison90 ashharrison90 requested review from joshhunt and L-M-K-B and removed request for a team May 24, 2023 15:10
@ashharrison90 ashharrison90 added add to changelog and removed no-changelog Skip including change in changelog/release notes labels May 24, 2023
@ashharrison90 ashharrison90 merged commit fd7f2d4 into main May 31, 2023
10 checks passed
@ashharrison90 ashharrison90 deleted the ash/confirm-modal branch May 31, 2023 15:20
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend area/grafana/ui Issues that belong to components in the @grafana/ui library no-backport Skip backport of PR saga design system Issues related to the work of the Saga Design System
Projects
Archived in project
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants