Chore: Adding "allowed_groups" Configuration Parameter to Generic OAuth Method #69025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsychov
requested review from
IevaVasiljeva and
danielkenlee
and removed request for
a team
|
|
grafanabot
added
area/backend
type/docs
pr/external
IevaVasiljeva
approved these changes
May 26, 2023
vsychov
changed the title
vsychov
changed the title
|
A small section of doc could be added under Apart from that implementation looks good 👍 , thanks for your contribution |
@Jguer, done. |
Jguer
approved these changes
May 30, 2023
grobinson-grafana
pushed a commit
that referenced
this pull request
May 31, 2023
…th Method (#69025) * feat: add allowed_groups for Generic OAuth * docs: add allowed_groups more docs for Generic OAuth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR introduces a new configuration parameter,
allowed_groups, for the Generic OAuth method.Why do we need this feature?
This new feature enhances the functionality of the Generic OAuth method by allowing the specification of groups that have access to the service. This allows for fine-tuned access control and increases security and specificity in permissions settings.
Who is this feature for?
This feature is beneficial for system administrators or developers who want to exert more precise control over who can access their services. It's especially useful in environments with a variety of user roles or teams that require different levels of access to the same services.
Which issue(s) does this PR fix?:
This PR is not directly address any existing issues.
Special notes for your reviewer:
Please check that: