-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Add more context to delete modals #69244
Conversation
Could you reverse the order of the buttons so that the destructive button is on the right? |
Do we need the info on the matchers? |
I think whether we need the info or not is debatable; the tree can be nested so any context is helpful to make sure the user is deleting the right policy. |
On the label matching topic: |
Yea I think that would work better, but those components are a work-in-progress and I'd rather not duplicate our efforts there; I'll revert the changes for the notification policies modal for now and that way we can at least merge some incremental improvements. |
…policies/Modals.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What is this feature?
Adds additional context to the delete modal so the user is aware of what they're asked to delete.
Affected modals in this PR: