JoinDataFrames: Keep field name if possible #69289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
added
area/transformations
no-backport
ryantxu
removed
the
no-changelog
ryantxu
requested review from
joshhunt,
ashharrison90 and
mckn
and removed request for
a team
leeoniya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69207 (though there may be additional issues)
When joining data using the legacy "Time/Value" fields where the name exists on the series, this PR updates the logic so that the series name is moved to the field name rather than sending it into labels.
This will make the names consistent between the first and second renders (why there are two renders is still another question!)