Alerting: Change how we display annotations in the rule form

[VikaCep]

What is this feature?

Changes how we display the section to add annotations when creating a rule. From now on Summary, Description and Runbook URL are always present as optional fields. Besides that, now we display de Dashboard name and Panel name when linked instead of just the id.

Why do we need this feature?

To make it simpler to use.

Who is this feature for?

All users.

Which issue(s) does this PR fix?:

Fixes #68200

[soniaAguilarPeiron]

I tested locally and I don't see the summary, description and runbook url fields when editing an existing alert rule, is this correct? 👀

[soniaAguilarPeiron]

Also in the prototype I see some changes in this button 👀

[VikaCep]

I tested locally and I don't see the summary, description and runbook url fields when editing an existing alert rule, is this correct? 👀

I asked Deyan and he confirmed we should always show the default fields. I fixed that in my last PR. It's pending to show them always in the same order though but I'll fix that next.

[konrad147]

I think there might be an edge case when it comes to the dashboard and panel link.

It might happen that an alert rule and a dashboard are in different folders, and the user editing the rule has no access to the dashboard and panel. Another example might be when the user has access to alert rules but has no access to dashboards (I think it's doable using RBAC).
In such a case, we need to handle permission errors and display something. The question is if we should allow to override the dashboard and panel in such cases or not.

Until we've displayed just an Id of a dashboard it wasn't an issue, but now we need to fetch a dashboard to display the name but in some cases we might receive 403 error, or the dashboard might be missing in the response (which doesn't indicate it actually doesn't exist, maybe the user just doesn't have the permission to see it)

It might require digging a bit deeper into how permissions work

[soniaAguilarPeiron]

Until we've displayed just an Id of a dashboard it wasn't an issue, but now we need to fetch a dashboard to display the name but in some cases we might receive 403 error, or the dashboard might be missing in the response (which doesn't indicate it actually doesn't exist, maybe the user just doesn't have the permission to see it)

What about showing a read only id and a warning in case user doesn't have permission? @konrad147 @VikaCep

[VikaCep]

I think there might be an edge case when it comes to the dashboard and panel link.

It might happen that an alert rule and a dashboard are in different folders, and the user editing the rule has no access to the dashboard and panel. Another example might be when the user has access to alert rules but has no access to dashboards (I think it's doable using RBAC). In such a case, we need to handle permission errors and display something. The question is if we should allow to override the dashboard and panel in such cases or not.

Until we've displayed just an Id of a dashboard it wasn't an issue, but now we need to fetch a dashboard to display the name but in some cases we might receive 403 error, or the dashboard might be missing in the response (which doesn't indicate it actually doesn't exist, maybe the user just doesn't have the permission to see it)

It might require digging a bit deeper into how permissions work

Good point. If the dashboard response doesn't return what we expect (a dashboard object with a title and a panel object) I added a fallback where we don't show links but a text indicating dashboard/panel id. Let me know what you think of this solution.

[soniaAguilarPeiron]

LGTM!🚀