Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

News: Expose config option to disable News feed #69365

Merged
merged 2 commits into from Jun 1, 2023
Merged

News: Expose config option to disable News feed #69365

merged 2 commits into from Jun 1, 2023

Conversation

ashharrison90
Copy link
Contributor

@ashharrison90 ashharrison90 commented Jun 1, 2023 •
edited

What is this feature?

  • exposes config option to disable news feed
  • removes override which hides news button on mobile
    • maybe controversial(?), but feels like we've got enough space and keeps behaviour consistent between mobile/desktop

Why do we need this feature?

  • more navigation customisation!

Who is this feature for?

  • everyone!

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ashharrison90 ashharrison90 added this to the 10.1.x milestone Jun 1, 2023
@ashharrison90 ashharrison90 self-assigned this Jun 1, 2023
@ashharrison90 ashharrison90 requested review from torkelo, a team and chri2547 as code owners June 1, 2023 10:09
@ashharrison90 ashharrison90 requested review from L-M-K-B, eledobleefe, academo, papagian, suntala and yangkb09 and removed request for a team June 1, 2023 10:09
@ashharrison90 ashharrison90 changed the title News: Expose config options to customise News feed News: Expose config options to disable News feed Jun 1, 2023
@ashharrison90 ashharrison90 changed the title News: Expose config options to disable News feed News: Expose config option to disable News feed Jun 1, 2023
@ashharrison90 ashharrison90 merged commit 7789638 into main Jun 1, 2023
19 checks passed
@ashharrison90 ashharrison90 deleted the ash/news-config branch June 1, 2023 12:35
ryantxu pushed a commit that referenced this pull request Jun 1, 2023
@ashharrison90 @ryantxu
News: Expose config option to disable News feed (#69365)
0113468 
* customize news feed

* remove url customisation
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkelo torkelo torkelo approved these changes

@chri2547 chri2547 Awaiting requested review from chri2547 chri2547 is a code owner

@L-M-K-B L-M-K-B Awaiting requested review from L-M-K-B L-M-K-B is a code owner automatically assigned from grafana/grafana-frontend-platform

@eledobleefe eledobleefe Awaiting requested review from eledobleefe eledobleefe is a code owner automatically assigned from grafana/grafana-frontend-platform

@academo academo Awaiting requested review from academo academo is a code owner automatically assigned from grafana/plugins-platform-frontend

@papagian papagian Awaiting requested review from papagian papagian was automatically assigned from grafana/backend-platform

@suntala suntala Awaiting requested review from suntala suntala was automatically assigned from grafana/backend-platform

@yangkb09 yangkb09 Awaiting requested review from yangkb09 yangkb09 was automatically assigned from grafana/backend-platform

Assignees

@ashharrison90 ashharrison90

Labels
add to changelog area/backend area/frontend area/navigation area/panel/news no-backport Skip backport of PR type/docs
Projects
Grafana Frontend Platform
Archived in project
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashharrison90 @torkelo @ricky-undeadcoders @grafanabot