Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard Navigation - Panel Query Editor]: Cannot access elements which are only visible on hover #69388

Closed
Tracked by #65701
polibb opened this issue Jun 1, 2023 · 1 comment · Fixed by #69731
Closed
Tracked by #65701
Assignees
Labels
area/frontend area/panel/edit effort/small MAS prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/accessibility Accessibility problem / enhancement wcag/2.1.1 Keyboard accessible - All content is operable through a keyboard interface

Comments

@polibb
Copy link
Contributor

polibb commented Jun 1, 2023

Steps to reproduce:
Open any dashboard. Create a panel with a DS Prometheus. Add a Sum field. Navigate to the new fields with a keyboard. Notice you cannot select any of the options inside the Sum field because they are only visible on hover

Screen.Recording.2023-06-01.at.17.31.41.mov

Expected Result
Can navigate to any options in any field using only keyboard.

Environment:

  • Grafana version: 10.0.0
@ckbedwell ckbedwell added the wcag/2.1.1 Keyboard accessible - All content is operable through a keyboard interface label Jun 5, 2023
@gtk-grafana gtk-grafana added effort/small prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jun 7, 2023
@gtk-grafana
Copy link
Contributor

This appears to be an issue with the icons in the Aggregation component, they are only visible on hover. Although they can still be selected via the keyboard, the outline is not visible, which is still not great for accessibility.

@grafana/observability-metrics will take a look and see if this can be fixed by updating the components in the Prometheus query builder, or if the grafana UI needs to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend area/panel/edit effort/small MAS prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/accessibility Accessibility problem / enhancement wcag/2.1.1 Keyboard accessible - All content is operable through a keyboard interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants