Tracing: Move upload trace to button #69402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrapereira
added
add to changelog
area/datasource/frontend
no-backport
joey-grafana
approved these changes
Jun 23, 2023
LudoVio
pushed a commit
that referenced
this pull request
Jun 26, 2023
* Tempo: Move upload trace to its own button * Zipkin: Move upload trace to its own button * Jaeger: Move upload trace to its own button * Fix test * Remove extra upload section from editor body --------- Co-authored-by: Joey Tawadrous <joey.tawadrous@grafana.com>
harisrozajac
pushed a commit
that referenced
this pull request
Jun 29, 2023
* Tempo: Move upload trace to its own button * Zipkin: Move upload trace to its own button * Jaeger: Move upload trace to its own button * Fix test * Remove extra upload section from editor body --------- Co-authored-by: Joey Tawadrous <joey.tawadrous@grafana.com>
harisrozajac
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Tempo: Move upload trace to its own button * Zipkin: Move upload trace to its own button * Jaeger: Move upload trace to its own button * Fix test * Remove extra upload section from editor body --------- Co-authored-by: Joey Tawadrous <joey.tawadrous@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
In an effort to simplify Tempo's query editor types, this PR moves the upload trace functionality to it's own button, which opens a modal that users can interact with to upload the trace.
The PR reuses some code from #61237, which can be closed since the branch is outdated and we won't be including the other changes until the TraceQL query editor is fully implemented and it's possible to move between the Ui editor and the code editor and keep the query, just like for LogQL and PromQL.
Related to #57407
Tempo
Jaeger
Zipkin
Modal that opens after clicking "Import Trace"
Who is this feature for?
Users of the Tempo, Zipkin and Jaeger datasources.
Special notes for your reviewer:
Please check that: