Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.0.x] Alerting: Fix provisioned templates being ignored by alertmanager #69488

Merged
merged 1 commit into from Jun 2, 2023

Conversation

JacobsonMT
Copy link
Member

Backport c16f1f5 from #69485

Manual backport, caused by innocuous merge conflict.

…9485)

* Alerting: Fix provisioned templates being ignored by alertmanager

Template provisioning sets the template in cfg.TemplateFiles while a recent change
made it so that alertmanager reads cfg.AlertmanagerConfig.Templates instead.

This change fixes the issue on both ends, by having provisioning set boths fields and
reverts the change on the alertmanager side so that it uses cfg.TemplateFiles.

(cherry picked from commit c16f1f5)
@JacobsonMT JacobsonMT added area/alerting Grafana Alerting area/backend backport A backport PR no-changelog Skip including change in changelog/release notes labels Jun 2, 2023
@JacobsonMT JacobsonMT requested a review from a team as a code owner June 2, 2023 20:00
@JacobsonMT JacobsonMT added this to the 10.0.x milestone Jun 2, 2023
Copy link
Contributor

@alexweav alexweav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacobsonMT JacobsonMT merged commit 0a6e80c into v10.0.x Jun 2, 2023
15 checks passed
@JacobsonMT JacobsonMT deleted the backport-69485-to-v10.0.x branch June 2, 2023 20:13
@zerok zerok modified the milestones: 10.0.x, 10.0.1 Jun 20, 2023
@zerok zerok added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Jun 21, 2023
zerok pushed a commit that referenced this pull request Jun 22, 2023
…anager (#69488)

Alerting: Fix provisioned templates being ignored by alertmanager (#69485)

* Alerting: Fix provisioned templates being ignored by alertmanager

Template provisioning sets the template in cfg.TemplateFiles while a recent change
made it so that alertmanager reads cfg.AlertmanagerConfig.Templates instead.

This change fixes the issue on both ends, by having provisioning set boths fields and
reverts the change on the alertmanager side so that it uses cfg.TemplateFiles.

(cherry picked from commit c16f1f5)
(cherry picked from commit 0a6e80c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants