Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend: Sort by name #69490

Merged
merged 8 commits into from
Jun 6, 2023
Merged

Legend: Sort by name #69490

merged 8 commits into from
Jun 6, 2023

Conversation

adela-almasan
Copy link
Contributor

@adela-almasan adela-almasan commented Jun 2, 2023

Added the ability to sort legend by name.
Removed viz sorting from Barchart as this functionality was already removed from time series (as discussed with @leeoniya).
Updated docs.

legend.sort.by.name.mov

Fixes #18186

Special notes for your reviewer:

  • added the "Name" header just to the sortable legends [Timeseries, Bar chart, Histogram]

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@adela-almasan adela-almasan added this to the 10.1.x milestone Jun 2, 2023
@adela-almasan adela-almasan requested a review from a team as a code owner June 2, 2023 20:26
@adela-almasan adela-almasan self-assigned this Jun 2, 2023
@adela-almasan adela-almasan added the area/panel/timeseries The main time series Graph panel label Jun 2, 2023
@leeoniya
Copy link
Contributor

leeoniya commented Jun 2, 2023

In table bottom - the legend stretches and the column name is displayed too far away from the actual value

any reason we can't always left-align the first header cell the same way the names are left-aligned? 🤔

@adela-almasan
Copy link
Contributor Author

I don't think there's any. To me it doesn't make sense to be that stretched out..

align_left

@adela-almasan adela-almasan marked this pull request as draft June 2, 2023 21:32
@adela-almasan adela-almasan changed the title Legend: Sort by name [WIP]Legend: Sort by name Jun 2, 2023
@adela-almasan adela-almasan changed the title [WIP]Legend: Sort by name Legend: Sort by name Jun 6, 2023
@adela-almasan adela-almasan marked this pull request as ready for review June 6, 2023 16:42
Copy link
Contributor

@leeoniya leeoniya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works for me :)

thanks!

Copy link
Collaborator

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adela-almasan adela-almasan merged commit 76b05b8 into main Jun 6, 2023
17 checks passed
@adela-almasan adela-almasan deleted the 18186_sort_legend_by_name branch June 6, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

legend table -> sort by name
5 participants