New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loki: Fix parsing of escaped quotes in LogQL #69584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyax
approved these changes
Jun 5, 2023
Backend code coverage report for PR #69584 |
Frontend code coverage report for PR #69584
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-69584-to-v10.0.x origin/v10.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x a81cee1d05ade7d09856ff4b7da1b6712382ee3e
# Push it to GitHub
git push --set-upstream origin backport-69584-to-v10.0.x
git switch main
# Remove the local backport branch
git branch -D backport-69584-to-v10.0.x Then, create a pull request where the |
grafanabot
added
the
backport-failed
Failed to generate backport PR. Please resolve conflicts and create one manually.
label
Jun 6, 2023
svennergr
added a commit
that referenced
this pull request
Jun 6, 2023
* fix parsing issue * replace escaped quotes (cherry picked from commit a81cee1)
svennergr
added a commit
that referenced
this pull request
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/frontend
backport v10.0.x
backport-failed
Failed to generate backport PR. Please resolve conflicts and create one manually.
datasource/Loki
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Parsing a visual representation of a query containing escaped quotes caused a bug. This PR fixes parsing of escaped quotes.
Special notes for your reviewer:
"line
value in the visualrepresentation is now correct - previously it was not.