Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: Use auth broker by default #69620

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Conversation

Jguer
Copy link
Contributor

@Jguer Jguer commented Jun 6, 2023

What is this feature?

  • Enable auth broker by default.
  • Add non documented option to disable auth broker for one last version

To disable the broker

[auth]
broker = false

@Jguer Jguer added add to changelog no-backport Skip backport of PR labels Jun 6, 2023
@Jguer Jguer added this to the 10.1.x milestone Jun 6, 2023
@Jguer Jguer requested a review from vtorosyan June 6, 2023 09:50
@Jguer Jguer requested a review from grafanabot as a code owner June 6, 2023 09:50
@Jguer Jguer self-assigned this Jun 6, 2023
@Jguer Jguer requested review from a team as code owners June 6, 2023 09:50
@Jguer Jguer requested review from summerwollin, dafydd-t, papagian, zserge and yangkb09 and removed request for a team June 6, 2023 09:50
Copy link
Contributor

@vtorosyan vtorosyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for future reader: auth broker is a new service used for authentication, despite the fact that there is no major feature/behavioural change, since the codepath is new, errors might happen. So if anything goes off with the auth scenarios, we can trace back to this change to debug further if there is any correlation.

@Jguer Jguer merged commit aee5c6d into main Jun 7, 2023
16 of 17 checks passed
@Jguer Jguer deleted the jguer/authnservice-toggle-config branch June 7, 2023 06:57
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants