Loki: Implement step editor #69648
Merged
Loki: Implement step editor #69648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
added
type/feature-request
datasource/Loki
add to changelog
no-backport
|
Backend code coverage report for PR #69648
|
|
Frontend code coverage report for PR #69648
|
|
Not sure if I'm doing anything wrong, but it doesn't matter what I put in step, I always get the same values:
Edit: I think there's something wrong with my local instance. |
hmm I didn't tested with split duration + split queries, so I'll have a look at that. Does it happen if you have split toggles off? |
|
No, it was my local Grafana instance. There was a zombie process with another branch in the background.
|
matyax
approved these changes
Jun 7, 2023
public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx
Show resolved
Hide resolved
…iQueryBuilderOptions.tsx Co-authored-by: Matias Chomicki <matyax@gmail.com>
JStickler
added a commit
to grafana/loki
that referenced
this pull request
Jun 7, 2023
**What this PR does / why we need it**: In grafana/grafana#69648 we are in Grafana introducing a step editor in Loki. Unfortunately, the error message when user sets too low step parameter is hard to understand, so I am proposing following change to make it more understandable and actionable. Let me know what do you think. --------- Co-authored-by: J Stickler <julie.stickler@grafana.com>
matyax
reviewed
Jun 9, 2023
gabor
approved these changes
Jun 16, 2023
public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx
Show resolved
Hide resolved
This was referenced Jun 19, 2023
Closed
LudoVio
pushed a commit
that referenced
this pull request
Jun 26, 2023
* Loki: Implement step editor * Update to keep value * Remove console.log * Remove white space * Update public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx Co-authored-by: Matias Chomicki <matyax@gmail.com> * Import trim * Update using of step in split queries * Add tests * Add tests * Remove step interpolation --------- Co-authored-by: Matias Chomicki <matyax@gmail.com>
harisrozajac
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Loki: Implement step editor * Update to keep value * Remove console.log * Remove white space * Update public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx Co-authored-by: Matias Chomicki <matyax@gmail.com> * Import trim * Update using of step in split queries * Add tests * Add tests * Remove step interpolation --------- Co-authored-by: Matias Chomicki <matyax@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
In this PR we are adding
stepeditor to Loki query editor. With a newstepeditor, users can set the value forstep. It accepts durations (e.g. 1s, 1d, 1h), numbers and $__interval or $__range variables.If the user set up the step, we use it. We don't do
safeStepevaluation on it, because we wantstepinput to be direct and we don't want "magic where we would adjust step" happening on the backend.I was thinking about adding validation, but I would like to add interpolation of template variables in the next PRs and then validation becomes more tricky, so I decided not to add it (at the moment). Moreover, other step editors (e.g. in Prometheus), also don't have validation, so I don't consider it as MVP and it can be added later (I added it as task in #58337)
Why do we need this feature?
Users would like to set the value of step parameter for metric query.
Who is this feature for?
Loki users who run metric queries
Which issue(s) does this PR fix?:
Part of #58337
Special notes for your reviewer:
step.mov