NestedFolders: Move New folder into a drawer
#69706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
added
area/frontend
add to changelog
no-backport
ashharrison90
requested review from
tskarhed and
JoaoSilvaGrafana
and removed request for
a team
tskarhed
reviewed
Jun 9, 2023
| subtitle={parentFolderTitle ? `Location: ${parentFolderTitle}` : undefined} | ||
| scrollableContent | ||
| onClose={() => setShowNewFolderDrawer(false)} | ||
| size="md" |
There was a problem hiding this comment.
Maybe "sm" would work better here? Otherwise there is a lot of whitespace
tskarhed
approved these changes
Jun 9, 2023
joshhunt
approved these changes
Jun 9, 2023
joshhunt
changed the title
New folder into a drawerNew folder into a drawer
academo
pushed a commit
that referenced
this pull request
Jun 12, 2023
* make New folder a drawer * use sentence case * extract strings and update tests * use sm drawer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
New folderfunctionality into a drawer (instead of a whole new page) to maintain contextNewFolderForm, we can remove the old components once nested folders is liveNew Dashboard/New Folderto sentence case, e.g.New dashboard/New folder`Why do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
Fixes #69693
Special notes for your reviewer:
Please check that: