InfluxDB: Backend parser compatibility with frontend parser #69865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmylife
added
datasource/InfluxDB
add to changelog
breaking change
13 tasks
# Conflicts: # pkg/tsdb/influxdb/response_parser_test.go
itsmylife
requested review from
gabor,
a team and
osg-grafana
and removed request for
a team
LudoVio
approved these changes
Jun 26, 2023
LudoVio
pushed a commit
that referenced
this pull request
Jun 26, 2023
* Reformatting and restructuring * Update unit test * Always send the default retention policy as first element * Fix typo * Update test * Update test once more * Field names start with capital letters * Simplify the condition * Case-insensitive checks * Fix typo * Update response_parser test * Update imports
harisrozajac
pushed a commit
that referenced
this pull request
Jun 29, 2023
* Reformatting and restructuring * Update unit test * Always send the default retention policy as first element * Fix typo * Update test * Update test once more * Field names start with capital letters * Simplify the condition * Case-insensitive checks * Fix typo * Update response_parser test * Update imports
harisrozajac
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Reformatting and restructuring * Update unit test * Always send the default retention policy as first element * Fix typo * Update test * Update test once more * Field names start with capital letters * Simplify the condition * Case-insensitive checks * Fix typo * Update response_parser test * Update imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
InfluxDB backend parser returns fields
TimeandValueinstead oftimeandvalueto be compatible with its predecessor frontend parser.Epic: #65045
Why do we need this feature?
Being compatible with InfluxDB frontend parser https://github.com/grafana/grafana/blob/main/public/app/plugins/datasource/influxdb/response_parser.ts#L185-L188
Who is this feature for?
InfluxDB users with the feature flag
influxdbBackendMigrationenabled.Which issue(s) does this PR fix?:
Special notes for your reviewer:
How to test (for users who did not enable
influxdbBackendMigrationfeature toggle before)InfluxQLJoin By Fieldand useTimefield.influxdbBackendMigrationNo DataHow to test (for users who enabled
influxdbBackendMigrationfeature toggle before)InfluxQLJoin By Fieldand usetimefield.No DataTimeRelease notice breaking change
InfluxDB backend parser returns incompatible data with frontend. The data was being parsed by frontend and we moving towards migrating InfluxDB fully backend. One caveat is Frontend is generating data frames with fields
TimeandValue. The backend parser, however, generatestimeandvalue. This is causing issues and inconsistencies for the features (i.e. transformations) relying on those. In order to have a unique approach we choose to support what most of the users already have. Existing Transformations that depend ontimefields have to be updated to useTimefields.