Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.0.x] Command Palette: Links opened in a new tab now route correctly when Grafana is served under a subpath #69925

Merged
merged 1 commit into from Jun 12, 2023
Merged

[v10.0.x] Command Palette: Links opened in a new tab now route correctly when Grafana is served under a subpath #69925

merged 1 commit into from Jun 12, 2023

Conversation

grafanabot
Copy link
Contributor

Backport 9eb8ec9 from #69845

@ashharrison90 @grafanabot
Command Palette: Links opened in a new tab now route correctly when G…
afebd49 
…rafana is served under a subpath (#69845)

don't strip base from url since we're not using locationSrv.push anymore

(cherry picked from commit 9eb8ec9)
@grafanabot grafanabot requested a review from a team as a code owner June 12, 2023 14:59
@grafanabot grafanabot requested review from joshhunt, eledobleefe, a team, ashharrison90 and L-M-K-B and removed request for a team, joshhunt and eledobleefe June 12, 2023 14:59
@grafanabot grafanabot added backport A backport PR no-changelog Skip including change in changelog/release notes type/bug labels Jun 12, 2023
ashharrison90
ashharrison90 approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm bot 🤖

@ashharrison90 ashharrison90 added this to the 10.0.x milestone Jun 12, 2023
@ashharrison90 ashharrison90 enabled auto-merge (squash) June 12, 2023 15:00
@ashharrison90 ashharrison90 merged commit 8111a42 into v10.0.x Jun 12, 2023
17 checks passed
@ashharrison90 ashharrison90 deleted the backport-69845-to-v10.0.x branch June 12, 2023 15:08
@zerok zerok modified the milestones: 10.0.x, 10.0.1 Jun 20, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 22, 2023
Merged
@jdbaldry jdbaldry mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashharrison90 ashharrison90 ashharrison90 approved these changes

@L-M-K-B L-M-K-B Awaiting requested review from L-M-K-B L-M-K-B is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees
No one assigned
Labels
add to changelog area/frontend backport A backport PR no-changelog Skip including change in changelog/release notes type/bug
Projects
None yet
Milestone
10.0.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grafanabot @ashharrison90 @zerok