Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudWatch: Add missing EventBridge Pipe metrics #69994

Conversation

rrhodes
Copy link
Contributor

@rrhodes rrhodes commented Jun 13, 2023

What is this feature?

Add missing EventBridge Pipe metrics to the AWS CloudWatch data source.

Which issue(s) does this PR fix?:

Fixes #69993

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@rrhodes rrhodes requested a review from a team as a code owner June 13, 2023 11:02
@rrhodes rrhodes requested review from fridgepoet and idastambuk and removed request for a team June 13, 2023 11:02
@CLAassistant
Copy link

CLAassistant commented Jun 13, 2023

CLA assistant check
All committers have signed the CLA.

@grafanabot grafanabot added area/backend datasource/CloudWatch pr/external This PR is from external contributor labels Jun 13, 2023
@rrhodes rrhodes force-pushed the feature/69993-add-missing-eventbridge-pipe-metrics branch from 0957b41 to 5fa7116 Compare June 13, 2023 11:04
@idastambuk
Copy link
Contributor

Hi @rrhodes thanks for the contribution! Just out of interest - do we have a timeline of AWS docs update you mentioned in the ticket?

@idastambuk idastambuk added this to the 10.1.x milestone Jun 14, 2023
@rrhodes
Copy link
Contributor Author

rrhodes commented Jun 15, 2023

Hi @idastambuk, the AWS EventBridge Pipes internal team have a request to update this documentation, but no ETA provided on when this will happen.

Looks like merging is blocked to authorised users only. Anything further I can do to help with this PR?

@rrhodes rrhodes changed the title feat: add missing eventbridge pipe metrics Add missing AWS EventBridge Pipe metrics Jun 15, 2023
@rrhodes rrhodes changed the title Add missing AWS EventBridge Pipe metrics CloudWatch: Add missing EventBridge Pipe metrics Jun 15, 2023
@idastambuk
Copy link
Contributor

Hi @idastambuk, the AWS EventBridge Pipes internal team have a request to update this documentation, but no ETA provided on when this will happen.

Looks like merging is blocked to authorised users only. Anything further I can do to help with this PR?

Hi @rrhodes sorry for the delay, merging now!

@idastambuk idastambuk merged commit 5f4d1d4 into grafana:main Jun 16, 2023
15 checks passed
@rrhodes rrhodes deleted the feature/69993-add-missing-eventbridge-pipe-metrics branch June 16, 2023 10:05
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudWatch: Add missing AWS/EventBridge/Pipes metrics
5 participants