EchoBackend: Make EchoSrvTransport batched #70012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpelelis
requested review from
ashharrison90 and
JoaoSilvaGrafana
and removed request for
a team
|
|
kpelelis
changed the title
domasx2
approved these changes
Jun 14, 2023
With the update of faro web sdk to 1.1.0, batching was introduced, in which several telemetry signals can be grouped together in a fixed interval or buffer length. The current setup in which the EchoSrvTransport was proxying signals through the Echo Backend was yielding the following issue. The updated Fetch transport is batched but the way it was being used by the `GrafanaJavascriptAgentBackend` was pushing single items.
kpelelis
force-pushed
the
make-echo-srv-transport-batched
branch
from
b278ce4
to
4b47298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
With the update of faro web sdk to 1.1.0, batching was introduced, in which several telemetry signals can be grouped together in a fixed interval or buffer length. The current setup in which the EchoSrvTransport was proxying signals through the Echo Backend was yielding the following issue.
The updated Fetch transport is batched but the way it was being used by the
GrafanaJavascriptAgentBackendwas pushing single items.Why do we need this feature?
The current state of the repository is not sending any telemetry signals to Faro.
Please check that: