Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard: Field Config - Add CFP franc currency (XPF) #70036

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Dashboard: Field Config - Add CFP franc currency (XPF) #70036

merged 1 commit into from
Sep 29, 2023

Conversation

smortex
Copy link
Contributor

@smortex smortex commented Jun 13, 2023

@smortex smortex requested review from a team as code owners June 13, 2023 22:25
@smortex smortex requested review from joshhunt, eledobleefe and academo and removed request for a team June 13, 2023 22:25
@CLAassistant
Copy link

CLAassistant commented Jun 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@grafanabot grafanabot added area/frontend pr/external This PR is from external contributor labels Jun 13, 2023
@grafanabot
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@grafanabot grafanabot added the stale Issue with no recent activity label Jul 14, 2023
@smortex smortex force-pushed the add-currency-xpf branch 2 times, most recently from cb42bda to b799d27 Compare July 14, 2023 02:42
@smortex smortex requested a review from a team as a code owner July 14, 2023 02:42
@smortex smortex requested review from axelavargas and kaydelaney and removed request for a team July 14, 2023 02:42
@smortex
Copy link
Contributor Author

smortex commented Jul 14, 2023

May I have a review please?

@grafanabot grafanabot removed the stale Issue with no recent activity label Jul 15, 2023
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale Issue with no recent activity label Aug 15, 2023
@github-actions github-actions bot removed the stale Issue with no recent activity label Aug 17, 2023
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale Issue with no recent activity label Sep 16, 2023
@axelavargas axelavargas changed the title Add CFP franc currency (XPF) Dashboard: Field Config - Add CFP franc currency (XPF) Sep 27, 2023
@axelavargas
Copy link
Member

Hey @smortex 👋🏾 , thank you for your patience with this PR. From my perspective, everything looks good 🏅. The next step is for you to resolve conflicts with the main branch, and it will be ready to merge.

@axelavargas axelavargas added this to the 10.2.x milestone Sep 27, 2023
@smortex
Copy link
Contributor Author

smortex commented Sep 28, 2023

Hey @axelavargas, I rebased my changes on top of the main branch and fixed the conflicts. Thank you!

@github-actions github-actions bot removed the stale Issue with no recent activity label Sep 28, 2023
axelavargas
axelavargas approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@axelavargas axelavargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @smortex 👋🏾 , thank you for resolving the conflicts, I left a minor comment about formatting.

@smortex
Currency: Add CFP franc (XPF)
2014136 
CFP franc has ISO 4217 currency code "XPF":
https://www.six-group.com/en/products-services/financial-information/data-standards.html

Signed-off-by: Romain Tartière <romain@blogreen.org>
@axelavargas
Copy link
Member

Dev Notes: Levitate is showing breaking changes, but when investigating it has nothing to do with the changes in this PR.

@axelavargas axelavargas merged commit 1c57217 into grafana:main Sep 29, 2023
14 of 16 checks passed
@smortex smortex deleted the add-currency-xpf branch September 29, 2023 18:00
rwwiv pushed a commit that referenced this pull request Oct 2, 2023
@smortex @rwwiv
Dashboard: Field Config - Add CFP franc currency (XPF) (#70036)
18830ee
mildwonkey pushed a commit that referenced this pull request Oct 4, 2023
@smortex @mildwonkey
Dashboard: Field Config - Add CFP franc currency (XPF) (#70036)
6e7d8f5
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
@dnhn dnhn mentioned this pull request Oct 24, 2023
Closed
@BrewTestBot BrewTestBot mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelavargas axelavargas axelavargas approved these changes

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt is a code owner automatically assigned from grafana/grafana-frontend-platform

@eledobleefe eledobleefe Awaiting requested review from eledobleefe eledobleefe is a code owner automatically assigned from grafana/grafana-frontend-platform

@academo academo Awaiting requested review from academo academo is a code owner automatically assigned from grafana/plugins-platform-frontend

@kaydelaney kaydelaney Awaiting requested review from kaydelaney kaydelaney is a code owner automatically assigned from grafana/dashboards-squad

Assignees
No one assigned
Labels
add to changelog area/frontend no-backport Skip backport of PR pr/external This PR is from external contributor
Projects
Dashboards
Archived in project
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@smortex @CLAassistant @grafanabot @axelavargas @zerok