Alerting: Bump grafana/alerting and refactor the ImageStore/Provider to provide image URL/bytes #70182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santihernandezc
added
add to changelog
no-backport
santihernandezc
requested review from
sakjur,
papagian and
yangkb09
and removed request for
a team
…ernandezc/refactor_image_store_implementation
yuri-tceretian
approved these changes
Jun 15, 2023
…ernandezc/refactor_image_store_implementation
santihernandezc
changed the title
santihernandezc
deleted the
santihernandezc/refactor_image_store_implementation
branch
LudoVio
pushed a commit
that referenced
this pull request
Jun 26, 2023
…to provide image URL/bytes (#70182) * implement alerting.images.Provider interface in our ImageStore * add URLExists() method to fakeConfigStore * make linter happy * update integration tests
harisrozajac
pushed a commit
that referenced
this pull request
Jun 30, 2023
…to provide image URL/bytes (#70182) * implement alerting.images.Provider interface in our ImageStore * add URLExists() method to fakeConfigStore * make linter happy * update integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
images.Providerinterface described in ourgrafana/alertingrepository (link).This new implementation has two methods:
GetImageURL(): Gets a URL that can be used directly in our notifications.GetRawImage(): Returns anio.ReadCloserto read the bytes of an image, useful for integrations that require the images to be uploaded.Other Changes
ImageStore->Provider(naming change).go.mod.URLExists()method in our store.Duplicate of #67693