Elasticsearch: Enable logs samples for metric queries #70258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend code coverage report for PR #70258 |
|
Frontend code coverage report for PR #70258
|
matyax
reviewed
Jun 16, 2023
public/app/plugins/datasource/elasticsearch/components/QueryEditor/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
ivanahuckova
approved these changes
Jun 22, 2023
ivanahuckova
changed the title
LudoVio
pushed a commit
that referenced
this pull request
Jun 26, 2023
* enable logs samples on elastic ds * add tests for getSupplementaryQuery * only display log samples for date_hostogram queries * changes * test * Update public/app/plugins/datasource/elasticsearch/datasource.test.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Update public/app/plugins/datasource/elasticsearch/datasource.test.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Update public/app/plugins/datasource/elasticsearch/datasource.test.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Update public/app/plugins/datasource/elasticsearch/datasource.test.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Update public/app/plugins/datasource/elasticsearch/datasource.test.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * address feedback / tests --------- Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
harisrozajac
pushed a commit
that referenced
this pull request
Jun 30, 2023
* enable logs samples on elastic ds * add tests for getSupplementaryQuery * only display log samples for date_hostogram queries * changes * test * Update public/app/plugins/datasource/elasticsearch/datasource.test.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Update public/app/plugins/datasource/elasticsearch/datasource.test.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Update public/app/plugins/datasource/elasticsearch/datasource.test.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Update public/app/plugins/datasource/elasticsearch/datasource.test.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Update public/app/plugins/datasource/elasticsearch/datasource.test.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * address feedback / tests --------- Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
this enables log samples for elasticsearch metric queries
Which issue(s) does this PR fix?:
Fixes #62212
Special notes for your reviewer:
Screen.Recording.2023-06-16.at.17.05.37.mov