New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InteractiveTable: Add pagination and header tooltips #70281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Added a question regarding documentation but I think the code looks good.
packages/grafana-ui/src/components/InteractiveTable/InteractiveTable.mdx
Outdated
Show resolved
Hide resolved
packages/grafana-ui/src/components/InteractiveTable/InteractiveTable.mdx
Show resolved
Hide resolved
@mckn Would you please merge this PR? I don't have permission. What would it take for one to get permission to merge? |
That is weird, you should have it via the groups you are in. Reach out to your manager and see what they say. |
* feat(interactiveTable): add pagination and header tooltips * docs: add note about client side pagination
* feat(interactiveTable): add pagination and header tooltips * docs: add note about client side pagination
What is this feature?
<InteractiveTable />
component.Why do we need this feature?
<InteractiveTable />
you need to slice your data into your page size chunks an implement your own<Pagination />
controls. Doing so breaks the ability to sort on any column because it will only sort the subset of rows you provide.Who is this feature for?
<InteractiveTable />
componentWhich issue(s) does this PR fix?:
Special notes for your reviewer:
Please check that: