Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InteractiveTable: Add pagination and header tooltips #70281

Merged
merged 2 commits into from Jun 29, 2023

Conversation

abannachGrafana
Copy link
Contributor

What is this feature?

  • <InteractiveTable /> component.
    • add pagination
    • add ability to show an icon and tooltip in the header

Why do we need this feature?

  • Pagination
    • Currently to paginate the <InteractiveTable /> you need to slice your data into your page size chunks an implement your own <Pagination /> controls. Doing so breaks the ability to sort on any column because it will only sort the subset of rows you provide.
  • Header tooltips
    • If the data in a column requires description of the value you may want to use a tooltip. With a lot of rows this can quickly overwhelm the page with icons. By allowing the addition of a tooltip in the header of the column you can efficiently describe the column's values without overwhelming the user.

Who is this feature for?

  • Users of the <InteractiveTable /> component

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@abannachGrafana abannachGrafana requested review from a team as code owners June 16, 2023 20:28
@abannachGrafana abannachGrafana requested review from mckn, tskarhed and JoaoSilvaGrafana and removed request for a team June 16, 2023 20:28
@CLAassistant
Copy link

CLAassistant commented Jun 16, 2023

CLA assistant check
All committers have signed the CLA.

@darrenjaneczek darrenjaneczek added this to the 10.1.x milestone Jun 21, 2023
@abannachGrafana abannachGrafana changed the title feat(interactiveTable): add pagination and header tooltips Feat: Add pagination and header tooltips to InteractiveTable Jun 23, 2023
Copy link
Contributor

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added a question regarding documentation but I think the code looks good.

@abannachGrafana
Copy link
Contributor Author

@mckn Would you please merge this PR? I don't have permission. What would it take for one to get permission to merge?

@mckn
Copy link
Contributor

mckn commented Jun 29, 2023

@mckn Would you please merge this PR? I don't have permission. What would it take for one to get permission to merge?

That is weird, you should have it via the groups you are in. Reach out to your manager and see what they say.

@mckn mckn changed the title Feat: Add pagination and header tooltips to InteractiveTable InteractiveTable: Add pagination and header tooltips Jun 29, 2023
@mckn mckn merged commit 0bbf011 into main Jun 29, 2023
16 checks passed
@mckn mckn deleted the adam.bannach/interactive-table branch June 29, 2023 06:22
harisrozajac pushed a commit that referenced this pull request Jun 29, 2023
* feat(interactiveTable): add pagination and header tooltips

* docs: add note about client side pagination
harisrozajac pushed a commit that referenced this pull request Jun 30, 2023
* feat(interactiveTable): add pagination and header tooltips

* docs: add note about client side pagination
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants