Loki: Deprecate resolution #70326
Merged
Loki: Deprecate resolution #70326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
added
add to changelog
no-backport
ivanahuckova
changed the title
ivanahuckova
requested review from
ashharrison90,
L-M-K-B and
jackw
and removed request for
a team
ivanahuckova
removed request for
lwandz13,
Eve832,
ashharrison90,
L-M-K-B and
jackw
|
Backend code coverage report for PR #70326 |
|
Frontend code coverage report for PR #70326
|
LudoVio
pushed a commit
that referenced
this pull request
Jun 26, 2023
* Loki: Deprecate resolution and only show it if it was selected before * Deprecate * Fix merge, add missing brackets
harisrozajac
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Loki: Deprecate resolution and only show it if it was selected before * Deprecate * Fix merge, add missing brackets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Prometheus, we have previously deprecated
Resolutionand only show it if users have already changed the value of resolution and saved it (in dashboard). The reason was to make it more straight forward and less confusing to set the step.In #69648 we have introduced step editor which offers a more precise way to set step. Therefore we have decided to go with the same approach as in Prometheus and deprecate
Resolution. This is done in a way, where resolution is still applied if you have query that uses it, but we are not showingResolutionto new users.We are using the same
Deprecatedstyle as in Elasticsearch editor.Part of #58337