Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs: Link anchored logline when opening context in split view #70463

Merged
merged 2 commits into from Jun 22, 2023

Conversation

svennergr
Copy link
Contributor

What is this feature?

With permalinking merged, we can now link anchored loglines from show text when opening this in a split view.

Special notes for your reviewer:

Screen.Recording.2023-06-21.at.17.35.43.mov

@svennergr svennergr added this to the 10.1.x milestone Jun 21, 2023
@svennergr svennergr requested a review from a team as a code owner June 21, 2023 15:38
@svennergr svennergr self-assigned this Jun 21, 2023
Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks INSANELY good!

@svennergr svennergr merged commit b5de806 into main Jun 22, 2023
13 checks passed
@svennergr svennergr deleted the svennergr/context-link branch June 22, 2023 12:00
LudoVio pushed a commit that referenced this pull request Jun 26, 2023
* add logline link id to context opened in split

* add comment
harisrozajac pushed a commit that referenced this pull request Jun 30, 2023
* add logline link id to context opened in split

* add comment
svennergr added a commit that referenced this pull request Jul 12, 2023
* add logline link id to context opened in split

* add comment
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants