Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.0.x] Dashboard: Fix issue where a panel with a description and a cached response displays 2 info icons #70566

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport fbfd1c2 from #70513


What is this feature?
Change the icon shown on panel notices to file-landscape-alt (This icon was selected after a discussion with our UX and some members of the team)

NewPanelNoticeInfoIcon.mp4

Why do we need this feature?
Two info icons are confusing

Who is this feature for?
everyone
Which issue(s) does this PR fix?:

Fixes #69509

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

…sponse displays 2 info icons (#70513)

(cherry picked from commit fbfd1c2)
@grafana-delivery-bot grafana-delivery-bot bot requested review from a team as code owners June 23, 2023 08:17
@grafana-delivery-bot grafana-delivery-bot bot removed the request for review from a team June 23, 2023 08:17
@grafana-delivery-bot grafana-delivery-bot bot added the backport A backport PR label Jun 23, 2023
@grafana-delivery-bot grafana-delivery-bot bot requested review from joshhunt and JoaoSilvaGrafana and removed request for a team June 23, 2023 08:17
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.0.x milestone Jun 23, 2023
@grafana-delivery-bot grafana-delivery-bot bot requested a review from mckn June 23, 2023 08:17
@grafanabot grafanabot added the pr/external This PR is from external contributor label Jun 23, 2023
Copy link
Member

@axelavargas axelavargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good bot 🤖

@axelavargas axelavargas enabled auto-merge (squash) June 23, 2023 08:19
@axelavargas axelavargas merged commit f06c6ea into v10.0.x Jun 23, 2023
17 of 18 checks passed
@axelavargas axelavargas deleted the backport-70513-to-v10.0.x branch June 23, 2023 08:25
@zerok zerok modified the milestones: 10.0.x, 10.0.2 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants