Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StateTimeline: Add disconnect value option #70610

Merged
merged 3 commits into from Jul 7, 2023

Conversation

drew08t
Copy link
Contributor

@drew08t drew08t commented Jun 23, 2023

What this PR does / why we need it:
Currently in state timeline, a user has the option to connect all null values or null values within a certain threshold of time range. Users do not however have the ability to disconnect non-null values that are outside of a time range from each other. This adds the option for users to disconnect non-null values that are outside of a threshold of time range.

Closes #70285

@drew08t drew08t marked this pull request as ready for review July 7, 2023 18:13
@drew08t drew08t requested a review from a team as a code owner July 7, 2023 18:13
@drew08t drew08t changed the title [WIP] StateTimeline: Add disconnect value option StateTimeline: Add disconnect value option Jul 7, 2023
Copy link
Contributor

@leeoniya leeoniya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, why not 😅

however, i would expect this to work differently with our default-on setting of "Merge equal consecutive values". e.g. the two consecutive green "a" states should be merged before this disconnect threshold is applied. currently not easy to get this working since disconnect happens first in the data while mergeValues happens later in the renderer. we may need to move the merging behavior into the data as well.

image

@leeoniya
Copy link
Contributor

leeoniya commented Jul 7, 2023

never mind the above comment, i think it's working as expected in that case. i did find some other weirdness to check out in a follow-up tho. notice how the rendering changes at the end with > 17m threshold:

http://localhost:3000/d/mIJjFy8Gz/timeline-modes?orgId=1&editPanel=9

Peek.2023-07-07.14-42.mp4

Copy link
Member

@ryantxu ryantxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me :)

@nmarrs nmarrs merged commit 2b7af77 into main Jul 7, 2023
14 checks passed
@nmarrs nmarrs deleted the drew08t/statetimeline-disconnect-values branch July 7, 2023 20:24
polibb pushed a commit that referenced this pull request Jul 14, 2023
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StateTimeline: Add disconnect feature
5 participants