-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trend: Support disconnect values and connect nulls options #70616
Conversation
(Open the links below in a new tab to go to the correct steps)
|
val = rangeUtil.intervalToMs(txt); | ||
} else { | ||
val = Number(txt); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block determines how we handle user input for threshold - by default isTime
is set to true
- in the case of trend panel we are passing false
in module.tsx
…f refFieldName is null / undefined; fix test
packages/grafana-ui/src/components/GraphNG/nullInsertThreshold.ts
Outdated
Show resolved
Hide resolved
packages/grafana-ui/src/components/GraphNG/nullInsertThreshold.ts
Outdated
Show resolved
Hide resolved
467dab4
to
c8bb9a8
Compare
@drew08t can you please take a look at breaking changes report? |
GraphNG and its util funcs are all internal, so these arent real breaking changes. do we know if annotating them with |
…ne for disconnect values + combo with connect nulls
Co-authored-by: Leon Sorokin <leeoniya@gmail.com> Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
What this PR does / why we need it:
Currently in trend, a user has the option to connect all null values or null values within a certain threshold of time range. Users do not however have the ability to disconnect non-null values that are outside of a time range from each other. This adds the option for users to disconnect non-null values that are outside of a threshold of time range.
Screen.Recording.2023-07-07.at.9.29.20.PM.mov
Closes #70284
Panel debug snapshot dashboard