Pyroscope: Preselect default profile type or app in the query editor dropdown #70624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aocenas
added
add to changelog
no-backport
aocenas
commented
Jun 23, 2023
public/app/plugins/datasource/grafana-pyroscope-datasource/QueryEditor/QueryEditor.tsx
Show resolved
Hide resolved
aocenas
commented
Jun 23, 2023
public/app/plugins/datasource/grafana-pyroscope-datasource/datasource.ts
Show resolved
Hide resolved
aocenas
commented
Jun 23, 2023
| @@ -101,6 +102,25 @@ export class PhlareDataSource extends DataSourceWithBackend<Query, PhlareDataSou | |||
| labelMatchers: extractLabelMatchers(tokens), | |||
| }; | |||
| } | |||
|
|
|||
| getDefaultQuery(app: CoreApp): Partial<Query> { | |||
There was a problem hiding this comment.
This makes initialization in explore a bit better so for the first render of query editor we get this instead of totally empty query object.
joey-grafana
approved these changes
Jun 28, 2023
harisrozajac
pushed a commit
that referenced
this pull request
Jun 29, 2023
harisrozajac
pushed a commit
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the drop down always preselected either a CPU profile or a first thing in the list.